Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i have added resize buttons in StickerItem.java,TextStickerView.java … #3090

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

i have added resize buttons in StickerItem.java,TextStickerView.java … #3090

wants to merge 6 commits into from

Conversation

SunitRoy2703
Copy link

Fixed #3041

Changes: I have added resize buttons in StickerItem.java,TextStickerView.java, which will make the App more user-friendly

Screenshots of the change:
StickerItem

Screenshot_2020-10-05-00-54-18-13_e9fa3137047667733754e6d84fae6a64 1

TextSticker

Screenshot_2020-10-05-00-52-45-74_e9fa3137047667733754e6d84fae6a64 1

abishekvashok
abishekvashok suggested changes Oct 5, 2020
View reviewed changes
Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it does seem nice, can you use a vector instead of a bitmap since the image shown is small.

@SunitRoy2703
Copy link
Author

SunitRoy2703 commented Oct 5, 2020 •
edited
Loading

Although it does seem nice, can you use a vector instead of a bitmap since the image shown is small.

I tried vector images at first, But All the code is written for taking a bitmap and the previous image and all the other images are in Bitmap. @abishekvashok

@SunitRoy2703
Copy link
Author

@mariobehling plz review

@SunitRoy2703
Copy link
Author

@iamareebjamal can you plz review

mariobehling
mariobehling requested changes Oct 26, 2020
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty nice, but we cannot move forward with failing builds. Please check Travis and fix the build. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling requested changes

@abishekvashok abishekvashok Awaiting requested review from abishekvashok

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resize button while adding a new sticker
3 participants
@SunitRoy2703 @mariobehling @abishekvashok